CHLCC intro sequence #78
Draft
+608
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newo-2001
commented
Oct 14, 2024
| if (type != 2) { | ||
| PopExpression(effect); | ||
| PopExpression(loop); | ||
| ScrWork[SW_SEREQNO + channel] = effect; | ||
| Audio::Channels[Audio::AC_SE0 + channel]->Volume = | ||
| (ScrWork[SW_SEVOL + channel] / 100.0f) * 0.3f; | ||
|
|
||
| // Hack to prevent playing the first sound byte before pausing |
There was a problem hiding this comment.
When pausing playback immediately after starting it, like this code does. A few milliseconds of sound is still played before it can be paused. This workaround is not a good solution, but I think we might have to extend the AudioChannel interface in order to support this use case.
newo-2001
force-pushed
the
chlcc-intro-animation
branch
from
903c692 to
2133aa1
Compare
newo-2001
force-pushed
the
chlcc-intro-animation
branch
from
7dd8399 to
6b4bda3
Compare
newo-2001
force-pushed
the
chlcc-intro-animation
branch
from
5df5c6d to
f2145d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for visiblity.
This PR adds some of the animations for the quite intricate CHLCC intro sequence which involves bouncing, exploding and falling stars.
To satisfy these needs, I added a new
PathAnimationclass which represents something moving along a path in space.One thing of note is that the sound that plays during the intro sequence is started from the script with a
type=1parameter. This was previously unimplemented but it seems to pause the playback of the audio immediately. This will then later be resumed by the drawing code in order to synchronize the sound with the star bouncing animation.